Re: [MacPerl] MPEdit

[ajf@afco.demon.co.uk (Alan Fry)]

Rich Morin <rdm@cfcl.com> writes 1 Dec 1998 17:24:32 -0800:

>> Suggestions, comments, and criticism would be most welcome.
>
>Comment:
>
>   The code is very clean-looking; I like that a lot!

Thanks indeed.

>Suggestions:
>
>*  Tidy up the last formatting problems, as:

[snip]

Agreed -- all of those suggestions help readability considerably. They will
will be in the next version for sure.

[/snip]

>Once you are SURE that $tc is in the range 20-23, you _could_ use it
>as an index into an anonymous array of functions.  I'm not sure the
>added complexity would be justified, however...

On the whole I try to avoid defining new variables whenever possible, but
in the case of '$tc' I think you're right. Creating it does clean it the
page up a lot. However I think '$tc' is probably better kept just as a
variable private to that procedure. It isn't needed anywhere else. It could
be put into the object hash I suppose, but I think that would be a move
towards, rather than away from, obfuscation on the whole.

Many thanks for your suggestions.

Alan Fry



***** Want to unsubscribe from this list?
***** Send mail with body "unsubscribe" to mac-perl-request@iis.ee.ethz.ch