At 8:16 PM -0700 1/25/99, Ero Brown wrote: } Hi, } } I wrote this search script and am submitting here for two reasons: } } a) I'm hoping some of you MacPerl experts can give me some } tips how to improve this script. } } b) I hope that it will be of some benefit to the MacPerl } community. } } Even though this script is intended to be generic (run on any } platform running Perl), I have been using it in MPW. It appears } to be faster and more flexible than the searching facilities } built into MPW. } } I would appreciate suggestions for improvements. Just a few comments after a not very careful reading. "my" is always recommended over "local" these days, for reasons having to do with how they work (local is actually a "save/restore" of a global variable, whereas my is lexical, which is more local than local(). Go figure). You're simply wasting a variable in GetHostOS; you can simply "return $^O;". It looks like you're reinventing a wheel or two here. You should become familiar with the Getopt:: modules. You should not, these days, use any of the *.pl files distributed with Perl, since they are legacy code. You might as well use File::Find directly, which gives you more control. } } Thanks, } } Ero Brown } } } } ----- Paul J. Schinder schinder@pobox.com ***** Want to unsubscribe from this list? ***** Send mail with body "unsubscribe" to mac-perl-request@iis.ee.ethz.ch